[Security Solution] migrate to new GET metadata list API #119123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeypoon
added
v8.0.0
release_note:skip
joeypoon
force-pushed
the
feature/migrate-get-endpoints-list
branch
2 times, most recently
from
223af0a to
ed4b32b
Compare
joeypoon
force-pushed
the
feature/migrate-get-endpoints-list
branch
from
ed4b32b to
1aaf9ca
Compare
💛 Build succeeded, but was flaky
Test Failures
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
Pinging @elastic/security-onboarding-and-lifecycle-mgt (Team:Onboarding and Lifecycle Mgt) |
joeypoon
added
release_note:enhancement
and removed
release_note:skip
2 tasks
joeypoon
commented
Nov 22, 2021
| dispatch({ | ||
| type: 'serverReturnedEndpointList', | ||
| payload: response, | ||
| }); | ||
|
|
||
| dispatchIngestPolicies({ http: coreStart.http, hosts: response.hosts, store }); | ||
| dispatchIngestPolicies({ http: coreStart.http, hosts: response.data, store }); |
There was a problem hiding this comment.
I was initially trying to migrate this to react query and hooks but there are some other dependencies on the data here in the middleware so probably best to scope that into its own ticket.
x-pack/plugins/security_solution/public/management/pages/endpoint_hosts/mocks.ts
Show resolved
Hide resolved
x-pack/plugins/security_solution/server/endpoint/routes/metadata/handlers.ts
Show resolved
Hide resolved
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 23, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Nov 23, 2021
…119506) Co-authored-by: Joey F. Poon <[email protected]>
3 tasks
dmlemeshko
pushed a commit
that referenced
this pull request
Nov 29, 2021
TinLe
pushed a commit
to TinLe/kibana
that referenced
this pull request
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate frontend to use new GET metadata list API introduced in #118968. No functional differences.
Also addressing some comments on the GET API from #118968.
Behavior is unchanged:
Checklist
For maintainers